search

CaiJimmy / hugo-theme-stack

Card-style Hugo theme designed for bloggers
https://stack.jimmycai.com
GNU General Public License v3.0
4.89k stars 1.6k forks source link

fix(comment): moved waline `placeholder` parameter to `locale.placeholder` #914

Closed L-Super closed 7 months ago

L-Super commented 10 months ago
  1. fix placeholder location
  2. update url

reference: https://waline.js.org/en/cookbook/customize/locale.html

L-Super commented 10 months ago

By the way, It seems that there is no visitor .

CaiJimmy commented 7 months ago

By the way, It seems that there is no visitor .

Yes, that must have been removed as well. If you find out what the new key of this option is, please open a new PR.

L-Super commented 7 months ago

By the way, It seems that there is no visitor .

Yes, that must have been removed as well. If you find out what the new key of this option is, please open a new PR.

The change seems to be a bit big, it can't simply implement the corresponding function through add and delete key. So, can you fix it? @CaiJimmy refer: https://waline.js.org/en/guide/features/pageview.html

https://waline.js.org/en/guide/features/comment.html

CaiJimmy commented 6 months ago

Actually, there's a bigger issue: the current version of Waline included within this theme is v2: https://github.com/CaiJimmy/hugo-theme-stack/blob/4948a3723e42fb775f4d895e4d173c5521be81b9/layouts/partials/comments/provider/waline.html#L1-L2

L-Super commented 6 months ago

Actually, there's a bigger issue: the current version of Waline included within this theme is v2:

https://github.com/CaiJimmy/hugo-theme-stack/blob/4948a3723e42fb775f4d895e4d173c5521be81b9/layouts/partials/comments/provider/waline.html#L1-L2

Could you upgrade to the latest version?

CaiJimmy commented 6 months ago

Actually, there's a bigger issue: the current version of Waline included within this theme is v2: https://github.com/CaiJimmy/hugo-theme-stack/blob/4948a3723e42fb775f4d895e4d173c5521be81b9/layouts/partials/comments/provider/waline.html#L1-L2

Could you upgrade to the latest version?

No, I don't use Waline and can't test if there are any compatibility issues with v3.