fix(sidebar): improve accessibility of sidebar bottom menu

CaiJimmy / hugo-theme-stack

Card-style Hugo theme designed for bloggers

https://stack.jimmycai.com

GNU General Public License v3.0

4.89k stars 1.6k forks source link

fix(sidebar): improve accessibility of sidebar bottom menu #925

Closed TheJiahao closed 7 months ago

TheJiahao commented 9 months ago

Move <div class="menu-bottom-section"> outside <ol class="menu" id="main-menu"> to fix warning <li> elements must be contained in a <ul> or <ol>
Add title="language" to language select menu to fix error Select element must have an accessible name: Element has no title attribute

The appearance is identical after change.

Before: before

After: after

ottok commented 7 months ago

(redacted)

ottok commented 7 months ago

Note that #950 is targeting the same section of code, so once either one is merged, the other one needs to be rebased.

cubercsl commented 7 months ago

@TheJiahao Could you confirm this change works fine in mobile size? I tried to cherry-pick this change to v4 branch, it seems that the language switcher disappeared.

TheJiahao commented 7 months ago

@cubercsl I can confirm that the bottom menu including language and theme switch is not showing in mobile. This will be fixed in PR #966.