Cairo-Dock / cairo-dock-core

Core part of Cairo-Dock project.
http://glx-dock.org
GNU General Public License v3.0
186 stars 46 forks source link

add desktop session files compatible with gnome-session 3.28 #7

Closed dkondor closed 4 years ago

dkondor commented 4 years ago

On newer Ubuntu version (with newer GNOME components), the old gnome-session files do not work well as unity-settings-daemon seems to be not fully usable.

In this branch, I've created session files that use the GNOME components, based on the gnome-flashback-session sessions (only replacing the gnome-panel with cairo-dock).

These require the gnome-flashback and gnome-session-flashback packages to be installed (on Ubuntu).

Tested on Ubuntu 18.04

fabounet03 commented 4 years ago

Hi, thank you for your patch! I carefully reviewed it, and I decided to not pull it directly, because it didn't work on Ubuntu 20.04. So I took your modifications and added what's needed to work also with more recent Gnome versions. Please let me know if everything is OK on Ubuntu 18.04.

Thanks again !

dkondor commented 4 years ago

Thanks, I just tried it from master and it work fine!

fabounet03 commented 4 years ago

Sweet ! :-) By the way I also fixed the gnome-flashback conflict within the same commits, if you can check it would be great (my Compiz crashes if I activate the Dbus plug-in so I can't verify).

dkondor commented 4 years ago

Hi,

I've just checked and the interaction with compiz is working as well.

Regarding compiz, unfortunately some combination of plugins make it crash sometimes :) -- I've recently submitted two merge proposals to fix crashes related to dbus: https://code.launchpad.net/~kondor-dani/compiz/+git/compiz/+ref/dbus-bool-fix https://code.launchpad.net/~kondor-dani/compiz/+git/compiz/+ref/dbus-fix which might help in this case as well.

Thanks for fixing that as well!

fabounet03 commented 4 years ago

Thank you for the confirmation!