search

Cairo-Dock / cairo-dock-plug-ins

Plugins of Cairo-Dock project.
http://glx-dock.org
GNU General Public License v3.0
39 stars 34 forks source link

Indicator: switch to Ayatana indicator #8

Closed kenhys closed 6 months ago

kenhys commented 4 years ago

libindicator is deprecated and it should be migrated to maintained upstream. at least Ubuntu bionic or later is supported (packaged).

https://ayatanaindicators.github.io/

fabounet03 commented 4 years ago

Hi ! Thank you for the commit, I get that libindicator is deprecated, but what about libido ? Shouldn't we also replace it with libayatana-ido3 then ? Also, when replacing the old libs with the new ones, is there really no API change ?

kenhys commented 4 years ago

Ah, we also need to replace it with libayatana-ido3, too. As far as I know ( I've migrated to libayatana case: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956770 ), libayatana is enough compatible with libindicator. This PR is focused to libindicator only.

fabounet03 commented 4 years ago

OK, do you think you could modify your patch to also address libido ? Otherwise it would make things incoherent.

kenhys commented 4 years ago

I've just tried to fix it too.

but I'm not so familiar to combination of supported options, so it may affects some components, Here is the list of componens:

fabounet03 commented 4 years ago

Hi, correct me if I'm wrong, but I think we missed a file in both commits: ./Indicator-applet3/indicator-applet3.c:30:#include <libindicator/indicator-ng.h> ./Indicator-applet3/indicator-applet3.c:31:#include <libido/libido.h>

kenhys commented 4 years ago

Hi,

I didn't touch these commit because it seems that it is a specialized code for ubuntu specific version of libindicator.

I'm not sure whether it is ok to enable IS_INDICATOR_NG (just removing #if IS_INDICATOR_NG for libayatana-indicator3)

This situation was introduced at this commit. https://github.com/Cairo-Dock/cairo-dock-plug-ins/commit/f449008e0089a6a6d316739b984f5a3d2bff3d24

It may be ok, but I couldn't confirm it yet. could you take over this PR, please?

dkondor commented 6 months ago

I've implemented this as part of #15 (incorporating the patches from Debian)

dkondor commented 6 months ago

I believe this is done by #15 -- but let us know if you see any issues. Thanks!