CaitlynMainer / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

Default username PircBotX not allowed by ircu #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use an unmodified PircBotX, don't override the login
2. Try to connect to an ircd-ircu server
3. Notice the "Your username is invalid" and subsequent disconnect.

What is the expected output? What do you see instead?

I expect to be connected, I see that I'm disconnected.

What version of the product are you using? On what operating system?

PircBot 1.6 on Ubuntu, ircd u2.10.12.10 (which is shipped in most recent 
version of Ubuntu, 11.10), and ircd u2.10.12.14 (most recent version)

Please provide any additional information below.

ircu has a "Check for mixed case usernames, meaning probably hacked" in its 
source (see attachment, line 279 onwards), that seems to be no less than 17 
years old! To summarize: it prevents usernames with more than two capitals. It 
works when the username is PircBot, or PircBotx, but not when it's PircBotX.

Not sure if you'd consider it a bug in PircBotX, but hey, it's a regression 
from PircBot!

Original issue reported on code.google.com by erik.bak...@lunatech.com on 4 Nov 2011 at 7:32

Attachments:

GoogleCodeExporter commented 9 years ago
O_o , wow. I'm not sure what I can say about that.

The issue here is that the project is called PircBotX, not PircBotx. Its 
everywhere with the X capitalized. I can't really justify changing the default 
name because an... interesting filter like that in a single server.

The only thing you can do is using PircBotX.setName() to change it to your 
preferred name. I recommend doing that anyway as on some servers your not the 
only one using PircBotX. 

Advantage with this bug report though is that anyone who runs into this issue 
in the future will know why since you researched it very well. Thanks

Original comment by Lord.Qua...@gmail.com on 4 Nov 2011 at 11:38

GoogleCodeExporter commented 9 years ago
I agree, that's fair.

Thanks for PircBotX :)

Original comment by erik.bak...@lunatech.com on 5 Nov 2011 at 9:54