CaitlynMainer / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

WEBIRC support #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

I'd like to request support for WEBIRC.

I'd look to request that 
http://wiki.mibbit.com/index.php/Enable_Mibbit_on_Your_IRC_Server

Alternatively, a hook after the connection is initiated, anything else is sent 
would work.

Currently around line 317:

http://code.google.com/p/pircbotx/source/browse/src/main/java/org/pircbotx/PircB
otX.java#317

Original issue reported on code.google.com by h...@pbrfrat.com on 23 Nov 2011 at 7:49

GoogleCodeExporter commented 9 years ago
I should have proofread that better, The wiki link was the only reference I 
could find for WEBIRC.

The second line should have read: "and before anything else is sent"

Either way, I noticed that the connect method is non final, unlike the original 
PircBot.  Thank you for enabling me to fix this myself!

Original comment by h...@pbrfrat.com on 23 Nov 2011 at 7:52

GoogleCodeExporter commented 9 years ago
Hmm, that is a difficult thing to implement. I can't think of an easy way to do 
it. I could add setters called setWebIrcPassword(), setWebIrcHostname(), and 
setWebIrcIp() and the appropiate getters, but I'm worried about adding methods 
to the already long setter and getter list.

Note that while you can override connect(), you would have to essentially copy 
and paste everything, which while it works is a bad way to do it.  If the 
WEBIRC line is literilly the first thing thats sent to the server a much easier 
way to accomplish this is to override createOutputThread and just send the 
WEBIRC line.

Original comment by Lord.Qua...@gmail.com on 23 Nov 2011 at 10:49

GoogleCodeExporter commented 9 years ago
Added relevant methods in Revision ac28e77a2ff0. The lines will only be sent if 
setWebIrcPassword is not null.

As for getting this out in a release, its fairly quiet in terms of issues. I'll 
wait about a week or two and if nothing else gets reported I'll push out a 
1.6.1 release since the change list is so small. For now though you can try 
1.7-SNAPSHOT

Original comment by Lord.Qua...@gmail.com on 2 Dec 2011 at 9:35

GoogleCodeExporter commented 9 years ago
Almost forgot

Original comment by Lord.Qua...@gmail.com on 2 Dec 2011 at 9:43