CakeDC / cakephp-oracle-driver

CakePHP 3 Driver for Oracle Database

Other

40 stars 25 forks source link

Apricotpoodle deprecated error + CloseCursor bug and rowCount() #44

Closed apricotpoodle closed 4 years ago

apricotpoodle commented 4 years ago

Description

Actual Behavior

Bugs :

Some deprecated messages
during mass insert : reach max limit of open cursor
RowCount : after sql command "DELETE ALL" warning message after statement is NULL

Expected Behavior

no deprecated errors messages
close cursor gently
check if statement is a ressource before checking rowCount.

Summarize

Code changed in :

src\Database\Statement\OCIStatement.php
src\Database\OCI8\OCIStatement.php

Benefits

This code solves some bug

Related Issues

???

skie commented 4 years ago

applied in 5.x branch