search

CakeDC / users

Users Plugin for CakePHP
https://www.cakedc.com
Other
521 stars 296 forks source link

Set type of email notification #947

Open ravage84 opened 3 years ago

ravage84 commented 3 years ago

Without this no email is sent.

This has become necessary after the following change from #685

https://github.com/CakeDC/users/pull/685/files#diff-087e5d4ddeb9b25aa37f089c2ce923ee418537310623b29d393404528f1797a3R73-R80

ravage84 commented 3 years ago

By the way, I haven't checked whether there are other places to adjust.

steinkel commented 3 years ago

Please could you describe the use case when email is not being sent? I'd like to cover it with a unit test.

Thanks,

ravage84 commented 3 years ago

Please could you describe the use case when email is not being sent? I'd like to cover it with a unit test.

Thanks,

I think we tried to send the reset password link through the CLI, thus the adjusted Shell class, but no mail was sent due to the recent change mentioned.

steinkel commented 3 years ago

Thank you, we'll try to reproduce the issue in a unit test and fix it, thanks!

steinkel commented 3 years ago

well, you fix it already ;) I mean merge it