Improve OTP code to handle session data in OneTimePasswordVerifyTrait not in LoginTrait

CakeDC / users

Users Plugin for CakePHP

https://www.cakedc.com

Other

520 stars 296 forks source link

Open rochamarcelo opened 2 years ago

rochamarcelo commented 2 years ago

This is related to #988 and more items.

Move session delete $this->getRequest()->getSession()->delete(AuthenticationService::TWO_FACTOR_VERIFY_SESSION_KEY); from LoginTrait::login to OneTimePasswordVerifyTrait
On verification page instead of redirecting to login after invalid code submit we should ask the code again

ajibarra commented 1 month ago

@rochamarcelo is this still valid?

rochamarcelo commented 3 weeks ago

yes