search

CakeML / regression

Regression testing infrastructure for CakeML
https://cakeml.org/regression.cgi
GNU General Public License v3.0
3 stars 8 forks source link

Workers track status and can restart tasks. #12

Closed talsewell closed 5 years ago

talsewell commented 5 years ago

The worker programs will now record what they're doing for any given job in status/job_(id)

If a task finishes, and the last line in status/job_(id) is 'Restart' then the worker will reattempt the task. This allows an admin to restart a task that has encountered a transient deadlock.

xrchz commented 5 years ago

Nice work. I think the job formatter on the server will need a slight tweak to handle the "Restarting task." lines. Can you add?

talsewell commented 5 years ago

Hmm, I don't really see what's the problem here. It looks like the formatting of the log is done by the client before pushing lines with Append.

xrchz commented 5 years ago

I think check process in serverLib.sml

talsewell commented 5 years ago

OK. I've had a look. Not my favourite design, I'll say that.

But, it ought to just work. The format_log_line function looks for lines with " Finished" and formats them, and falls back to a default case for all the other line types ("Starting ...", "Claimed job" etc). New default cases should just work, as long as they don't contain the string "Finished " anywhere.

xrchz commented 5 years ago

OK let's see how it goes