search

CakeML / regression

Regression testing infrastructure for CakeML
https://cakeml.org/regression.cgi
GNU General Public License v3.0
3 stars 8 forks source link

Filter labels #15

Closed talsewell closed 5 years ago

talsewell commented 5 years ago

Adds code that request and parses the labels of PRs on githubs.

Filters out PRs that have the "test failing" label.

It's type correct, but I don't have an easy way to test it.

talsewell commented 5 years ago

Thanks for comments, I agree with nearly everything.

I think that a little refactoring around the read_opt_list awkwardness might be reasonable. I wanted to make as few edits as possible in this instance, especially since it's fiddly to test.

If refactoring is an option, one bigger thing I'd consider is separating the response parser out from the API query, so that it would be possible to load the response parser into a poly session and test it against output from the explorer.

xrchz commented 5 years ago

I'd be happy to see the lager refactoring, either as part of this PR or (perhaps better) separately afterwards.

xrchz commented 5 years ago

Would love to see the minor things fixed here first so we can merge it :)

talsewell commented 5 years ago

Ah yes, I'll put this back on my to-do list.

talsewell commented 5 years ago

OK, I've made some changes.

talsewell commented 5 years ago

OK, I've updated again.

talsewell commented 5 years ago

OK, I think everything is addressed.

xrchz commented 5 years ago

Awesome!