search

CakeML / regression

Regression testing infrastructure for CakeML
https://cakeml.org/regression.cgi
GNU General Public License v3.0
3 stars 8 forks source link

Show PR branch names in job types #20

Closed xrchz closed 5 years ago

xrchz commented 5 years ago

Hey Ale, can you have a look over this to see if it looks OK? Also, maybe you can run it on your server to see if it looks good?

agomezl commented 5 years ago

Yep, references are written into the files within parentheses

https://github.com/CakeML/regression/blob/5030f16bff8dc9909060cab069f7e410efdb40a4/serverLib.sml#L154

agomezl commented 5 years ago

We should consider changing the name of the column from type into something more meaningful like branch or reference

agomezl commented 5 years ago

Thank you for making the changes to the column name and the email message = )

agomezl commented 5 years ago

In the list of jobs the branch information still appears in parenthesis, which in my opinion is unnecessary

2019-05-15-103230_224x117_scrot

I proposed some changes to fix that, take a look

xrchz commented 5 years ago

Agreed - I removed the parentheses slightly differently.

xrchz commented 5 years ago

Any chance of getting this approved? :)

agomezl commented 5 years ago

Sorry!! got distracted