search

CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

Bootstrap 4 - Breadcumb #103

Closed Emilvooo closed 6 years ago

Emilvooo commented 7 years ago

Hi!

When using the HTML helper it does the breadcrumbs wrong. Instead of ol its does ul. Also the classes in the li are wrong.

This is what it should be in Bootstrap 4: http://getbootstrap.com/components/#breadcrumbs

And i do indeed use the bootstrap 4 variant of the plugin. `

breadcrumb breadcrumb-code

Holt59 commented 7 years ago

Hi,

The v4 branch is currently outdated, I was waiting for a more stable release of bootstrap 4 to refactor it.

Note that the getBreadcrumbs method is deprecated for a more generic BreadcrumbsHelper in CakePHP.

I will try to update the v4 branch once I've finished cleaning the documentation of the current branch.

Emilvooo commented 7 years ago

Alright, thanks!

Holt59 commented 6 years ago

I am closing this in favor of a more generic issue #153, feel free to comment there if you have any feedback!