CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

Modal size broken? #117

Closed mferak closed 7 years ago

mferak commented 7 years ago

Hi! When trying to create a modal with the size option "lg", the markup seems to be wrong.

According to bootstrap's documentation, it should be

<div class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myLargeModalLabel">
  <div class="modal-dialog modal-lg" role="document">
    <div class="modal-content">
      ...
    </div>
  </div>
</div>

but what I get instead is

<div class="modal fade modal-lg" tabindex="-1" role="dialog" aria-labelledby="myLargeModalLabel">
  <div class="modal-dialog" role="document">
    <div class="modal-content">
      ...
    </div>
  </div>
</div>

The resulting modal is not large, and positioned off-center to the left.

Is there an easy way to fix this?

PS: Thanks for the great plugin.

Holt59 commented 7 years ago

I think Bootstrap change the target for the class in a recent version. I'll push a fix as soon as I can (this is an easy fix but I do not have access to a working dev environment right now).

Holt59 commented 7 years ago

Should be fixed by ba8cb3f9e763ab3cba1dd7ede35e5b64b080bb81.

mferak commented 7 years ago

Thank you so much!

Holt59 commented 7 years ago

I am closing this, feel free to open a new issue if you have any problem!