Add option for dropdownButton

CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.

https://holt59.github.io/cakephp3-bootstrap-helpers/

MIT License

130 stars 79 forks source link

Add option for dropdownButton #129

Closed innovaweb-dev closed 7 years ago

innovaweb-dev commented 7 years ago

This pull add option "dropdown-menu-right". To default, the dropdownButton is aligned to left. The align property if it is set, waits for the 'right' or 'left' values.

Holt59 commented 7 years ago

@rifton007 Actually, this should go to HtmlHelper::dropdown, and the FormHelper::dropdown should only forward the align option to the HtmlHelper::dropdown (or something similar), could you modify that?

innovaweb-dev commented 7 years ago

I tried, but I do not understand how to do it. Could you explain to me how to do it and I would do it with pleasure. Sorry to not be able to do better.

Holt59 commented 7 years ago

@rifton007 I'll merge this pull request this week-end to a separate branch and make the change to the test cases before merging it to the master branch.

innovaweb-dev commented 7 years ago

Thank you Holt 59, I will watch your changes to better understand. Sorry still not to be able to do it myself.

Holt59 commented 7 years ago

I have merged this PR to the pr129 branch. I will probably move the part to the Html helper, and add the necessary tests.

Holt59 commented 7 years ago

I have fixed issue with the PR and the tests:

I have moved the align option to HtmlHelper::dropdown (it probably belongs here rather than in the FormHelper);
I have forwarded the align option from FormHelper::dropdown to HtmlHelper::dropdown (and in the same time added a way to easily add new forwarding options);
I have fix the tests, all that was needed was to add the dropdown-menu-left class to the generated dropdown (since it is now added by default).

Thanks again for the initial PR!

innovaweb-dev commented 7 years ago

Thank you @Holt59 Thanks to you for this plugin and all the work you do