CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

Generated links for next and previous page neglects url option #131

Open Antoniossss opened 7 years ago

Antoniossss commented 7 years ago

using version 3.0.7 For example i have following options:

$paginationOptions = [
    "size" => "small",
    "prev" => "<",
    "next" => ">",
    "ellipsis" => true,
    "first" => "first",
    "last" => "last",
    "url" => [
        "#" => "results-panel"
    ]
];

And I use it like this: $this->Paginator->numbers($paginationOptions);

Links like 1,2,3,4,5.... etc contains proper anchor #results-panel. Previous and next links on the other hand does not.

Holt59 commented 7 years ago

Do first and last link have the anchor set appropriately?

Antoniossss commented 7 years ago

I have just checked that and no, they do not.

Holt59 commented 7 years ago

For next and prev, you can do the following:

$paginationOptions = [
    'next' => [
        'title' => '<',
        'url' => ['#' => 'results-panel']
    ]
]

I only forward first and last to the standard PaginatorHelper::numbers() methods, so I don't know if it will also work with first and last.

Holt59 commented 7 years ago

Digging a bit into the standard paginator helper, you may be able to do (not tested, not really sure... ):

$this->Paginator->options(['url' => ['#' => 'results-panel']]);
echo $this->Paginator->numbers($paginationOptions);