search

CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

Prepare for CakePHP 3.6: Remove deprecations #147

Closed raul338 closed 6 years ago

raul338 commented 6 years ago

Fix Tests and Helpers to remove deprecation warnings introduced in CakePHP 3.6

codecov[bot] commented 6 years ago

Codecov Report

Merging #147 into master will decrease coverage by 0.17%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #147      +/-   ##
============================================
- Coverage     89.11%   88.94%   -0.18%     
  Complexity      372      372              
============================================
  Files            19       19              
  Lines          1158     1158              
============================================
- Hits           1032     1030       -2     
- Misses          126      128       +2
Impacted Files Coverage Δ Complexity Δ
src/View/Helper/UrlComparerTrait.php 100% <100%> (ø) 25 <0> (ø) :arrow_down:
src/View/Helper/PanelHelper.php 90.53% <100%> (ø) 45 <0> (ø) :arrow_down:
src/View/Helper/FormHelper.php 83.63% <100%> (ø) 53 <0> (ø) :arrow_down:
src/View/Widget/FancyFileWidget.php 94.33% <0%> (-3.78%) 12% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2772e08...da04c3d. Read the comment docs.

Holt59 commented 6 years ago

Merging directly into master since it is compatible with CakePHP 3.4, will merge to v3.2.1 as soon as possible.