search

CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

session() deprecation fix #148

Closed asgraf closed 6 years ago

asgraf commented 6 years ago

Quick fix to get rid of cakephp 3.6 deprecation error

codecov[bot] commented 6 years ago

Codecov Report

Merging #148 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #148   +/-   ##
=========================================
  Coverage     88.94%   88.94%           
  Complexity      372      372           
=========================================
  Files            19       19           
  Lines          1158     1158           
=========================================
  Hits           1030     1030           
  Misses          128      128
Impacted Files Coverage Δ Complexity Δ
src/View/Helper/FlashHelper.php 0% <0%> (ø) 5 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7243e23...da31fee. Read the comment docs.

Holt59 commented 6 years ago

Thanks for the pull-request. getSession() is a CakePHP 3.5 addition, so this would change the minimum requirements to use these helpers, I need to see if I am ready to switch to 3.5.

Holt59 commented 6 years ago

I've merged this, thanks for the PR, requirements have been upgrade to >= 3.5.0. I will add FlashHelper for future PR.