search

CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

Remove code duplication #150

Closed ypnos-web closed 6 years ago

ypnos-web commented 6 years ago

This method mirrors the one by CakePHP that it overrides.

Holt59 commented 6 years ago

Thanks for the PR, I did not notice this change in StringTemplate, funny ;) Tests are broken due to CakePHP 3.6, I don't know why, I need to fix this...

Holt59 commented 6 years ago

@ypnos-web I fixed the test for CakePHP 3.6 and added multiple versions for Travis CI to avoid such issue in the future.