search

CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

Add confirmJs template in FormHelper.php to fix Cannot find template … #168

Closed toggenation closed 5 years ago

toggenation commented 5 years ago

Running the 4.0.1-alpha release and just updated to CakePHP 3.7.1 and received an error

Error: [RuntimeException] Cannot find template named 'confirmJs'.

So have added the confirmJs key to src/View/Helper/FormHelper.php templates array.

https://api.cakephp.org/3.7/class-Cake.View.Helper.HtmlHelper.html

Holt59 commented 5 years ago

Thanks for the PR. I will merge this manually with the other fix and some other depreciations from CakePHP 3.7.1.

Holt59 commented 5 years ago

I wanted to cherry-pick this from your repository to keep authorship but you made a modification on the master branch and not the 4.0.1-alpha so a clean cherry-pick is not possible. Would you mind making this change on your 4.0.1-alpha branch? If you do not care about authorship I can make the change by myself.

Holt59 commented 5 years ago

@jmcd73 Forget my previous comment, I did not see that the fix was included in the other commit.