search

CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

4.0.1 alpha #183

Closed alexdd55 closed 2 years ago

alexdd55 commented 5 years ago

Added missing return types as cakephp 4.x requested

Holt59 commented 5 years ago

Hi @alexdd55, the 4.0.1-alpha branch is for Bootstrap 4, not CakePHP 4. Are you looking for CakePHP 4.x + Bootstrap 3 or CakePHP 4.x + Bootstrap 4?

alexdd55 commented 5 years ago

oh, thats a misunderstanding. branch names seems to be very confusing at this point. in what branch would it actually fit?

Am Mi., 21. Aug. 2019 um 13:49 Uhr schrieb Mikaël Capelle < notifications@github.com>:

Hi @alexdd55 https://github.com/alexdd55, the 4.0.1-alpha branch is for Bootstrap 4, not CakePHP 4.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Holt59/cakephp3-bootstrap-helpers/pull/183?email_source=notifications&email_token=AAEZVOCWU6PKYTHO3DQW4WTQFUTTPA5CNFSM4IOFY7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4ZMSBY#issuecomment-523421959, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEZVOGGVEUJAUE2BV7D26LQFUTTPANCNFSM4IOFY7LA .

Holt59 commented 5 years ago

@alexdd55 I would have to rethink my branch naming for CakePHP 4, maybe c.b.v where c is the CakePHP version, b the bootstrap and c the actual version, e.g., 4.3.1 for CakePHP 4, Bootstrap 3, version 1.

There is an issue with your PR in that you've forked branch 4.0.1-alpha which is meant for Bootstrap 4, but panels are not in Bootstrap 4, they've been replaced by Card (https://github.com/Holt59/cakephp3-bootstrap-helpers/blob/4.0.1-alpha/src/View/Helper/CardHelper.php).

alexdd55 commented 5 years ago

renaming sounds good 👍👍

i need to check back for that issue, because cake however gave me the error that panelHelper is needed, so i took it from other branch and the error was gone

Am Mi., 21. Aug. 2019 um 15:49 Uhr schrieb Mikaël Capelle < notifications@github.com>:

@alexdd55 https://github.com/alexdd55 I would have to rethink my branch naming for CakePHP 4, maybe c.b.v where c is the CakePHP version, b the bootstrap and c the actual version, e.g., 4.3.1 for CakePHP 4, Bootstrap 3, version 1.

There is an issue with your PR in that you've forked branch 4.0.1-alpha which is meant for Bootstrap 4, but panels are not in Bootstrap 4, they've been replaced by Card ( https://github.com/Holt59/cakephp3-bootstrap-helpers/blob/4.0.1-alpha/src/View/Helper/CardHelper.php ).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Holt59/cakephp3-bootstrap-helpers/pull/183?email_source=notifications&email_token=AAEZVOGG7GNXYPK7CXSDJF3QFVBXBA5CNFSM4IOFY7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4ZXHKY#issuecomment-523465643, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEZVOAKZWRJLEJDA4BARO3QFVBXBANCNFSM4IOFY7LA .

Holt59 commented 5 years ago

@alexdd55 Are you using Bootstrap 3 or 4? If you're using Bootstrap 3, you should fork from master instead of 4.0.1-alpha.

alexdd55 commented 5 years ago

i use bootstrap 4. latest release.

Am Mi., 21. Aug. 2019 um 16:55 Uhr schrieb Mikaël Capelle < notifications@github.com>:

@alexdd55 https://github.com/alexdd55 Are you using Bootstrap 3 or 4? If you're using Bootstrap 3, you should fork from master instead of 4.0.1-alpha.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Holt59/cakephp3-bootstrap-helpers/pull/183?email_source=notifications&email_token=AAEZVOGMUJ5XOIIMW2NG553QFVJNDA5CNFSM4IOFY7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Z6GSI#issuecomment-523494217, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEZVOCOETFX5XUKVTJ7SR3QFVJNDANCNFSM4IOFY7LA .

alexdd55 commented 5 years ago

found my mistake i made in the first place. i c&p the helpers, but those are for bootstrap3 (inkl. panels) ... this might be the reason... i will kick out the panelHelper and check back after that

Am Mi., 21. Aug. 2019 um 16:55 Uhr schrieb Mikaël Capelle < notifications@github.com>:

@alexdd55 https://github.com/alexdd55 Are you using Bootstrap 3 or 4? If you're using Bootstrap 3, you should fork from master instead of 4.0.1-alpha.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Holt59/cakephp3-bootstrap-helpers/pull/183?email_source=notifications&email_token=AAEZVOGMUJ5XOIIMW2NG553QFVJNDA5CNFSM4IOFY7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Z6GSI#issuecomment-523494217, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEZVOCOETFX5XUKVTJ7SR3QFVJNDANCNFSM4IOFY7LA .