search

CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

CakePHP 4 support #190

Open Erwane opened 4 years ago

Erwane commented 4 years ago

I'm using this plugin since years now and i want to create a PR to support Cakephp4 with bootstrap4.

From which branch should i start please ?

Holt59 commented 4 years ago

You should start with the https://github.com/Holt59/cakephp3-bootstrap-helpers/tree/v4.0.3 branch.

Erwane commented 4 years ago

Thanks, i'm on it.

I'm looking the project name and versions and do you plan to rename it "cakephp-bootstrap-helpers" and think about a notation branchs for versions ? cake3-bootstrap3, cake3-bootstrap4, cake4-bootstrap4 ?

Erwane commented 4 years ago

in progress : https://github.com/Erwane/cakephp3-bootstrap-helpers/tree/cake4-compatibility

Holt59 commented 4 years ago

@Erwane Thanks for all the work!

I have to check what implies a renaming of the Github project, I think Github can provide a redirection to the new project from the old URL but I'd have to check.

For the version, it's a bit more complicated unfortunately... For the branch names, there are currently no issues, but for composer to work properly there are some constraints on tagging (e.g., if you want 3.2.* or something like that).

Erwane commented 4 years ago

Proposal :

We only have "patch" (x) and "release" (y) numbers for new helpers or fixes.

In composer : composer require holt59/cakephp-bootstrap:"^3.4.0" for cake 3 with bootstrap 4

Holt59 commented 4 years ago

@Erwane Yes, I think it's the best idea. And it does not break current versions which is a good thing. I will try to move everything to the new scheme this week-end and update the README(s) accordingly.