CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

Add `selected` template as defined in CakePHP 3.9 #192

Closed raul338 closed 3 years ago

raul338 commented 3 years ago

Update the template array in FormHelper, added in 3.9 in cakephp/cakephp#13686

Otherwise it throws a RuntimeException when using MultipleCheckbox

codecov[bot] commented 3 years ago

Codecov Report

Merging #192 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage     88.86%   88.86%           
  Complexity      368      368           
=========================================
  Files            19       19           
  Lines          1150     1150           
=========================================
  Hits           1022     1022           
  Misses          128      128           
Impacted Files Coverage Δ Complexity Δ
src/View/Helper/FormHelper.php 83.73% <ø> (ø) 53.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b839973...1210690. Read the comment docs.

Erwane commented 3 years ago

Right. But should be added in

raul338 commented 3 years ago

Yes, those should be in another commits, as I'm using cake 3 with bootstrap 3.

Maybe cherry-pick the commit?

Holt59 commented 3 years ago

These cannot be cherry-picked directly due to conflicts. I can make the change myself to the other branches but you can open PRs if you want to keep authorship on this.

raul338 commented 3 years ago

Thank you. Nevermind about authorship, its just a line.

Maybe you should make a release with this fix? In the meantime it can be fixed by adding the line in the project's AppView