search

CakePHP-Bootstrap / cakephp3-bootstrap-helpers

CakePHP 3.x Helpers for Bootstrap 3 and 4.
https://holt59.github.io/cakephp3-bootstrap-helpers/
MIT License
130 stars 79 forks source link

WIP: Helpers keep default config for robustness #195

Open Erwane opened 3 years ago

Erwane commented 3 years ago

It's a try to prevent addition in Cake helpers will break the code.

Bootstrap helper is in $helperConfig and merged to $_defaultConfig. This way, templates and widgets always have a correct default and follow framework.

Work in progress, need to do all helpers if good way.

codecov[bot] commented 3 years ago

Codecov Report

Merging #195 (96ef936) into cake4-bs4-1.0.0 (2767409) will increase coverage by 0.68%. The diff coverage is 73.33%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             cake4-bs4-1.0.0     #195      +/-   ##
=====================================================
+ Coverage              86.63%   87.32%   +0.68%     
- Complexity               380      382       +2     
=====================================================
  Files                     19       19              
  Lines                   1190     1183       -7     
=====================================================
+ Hits                    1031     1033       +2     
+ Misses                   159      150       -9
Impacted Files Coverage Δ Complexity Δ
src/View/Helper/FormHelper.php 85.32% <73.33%> (+0.16%) 60.00 <24.00> (+2.00)
src/View/Widget/ColumnSelectBoxWidget.php 0.00% <0.00%> (ø) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2767409...96ef936. Read the comment docs.