search

CalCOFI / OceanView

App that can incentivize ocean users to report their observations
1 stars 0 forks source link

Fix lat/long and pop dialog when returning from observation #20

Closed hundredball closed 1 year ago

hundredball commented 1 year ago

Main changes

mfrants commented 1 year ago

Hi Chieh

I checked out the bugfix/lat_long branch today and tried it out (using the Android simulator). The pop-up dialog works fine, but lat and long on the observation page are still showing zeros rather than current location. Is this because I'm running on a simulator rather than an actual phone? Is there a way I can test it out? The code looks good to me.

Marina Frants Information Manager, CCE-LTER and CalCOFI Scripps Institution of Oceanography @.***

On Mon, Feb 27, 2023 at 7:36 AM Chieh Hsu @.***> wrote:

@hundredball https://urldefense.com/v3/__https://github.com/hundredball__;!!Mih3wA!GSfD6YNAidhEV_nvA7z61bof44HOvzbOXJI7A_0Fo6TgWKmW6wX4LHMOzA_y_BIxMk92irs-byq54ahoM-rzN1q9$ requested your review on: #20 https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/pull/20__;!!Mih3wA!GSfD6YNAidhEV_nvA7z61bof44HOvzbOXJI7A_0Fo6TgWKmW6wX4LHMOzA_y_BIxMk92irs-byq54ahoMxZP_YZX$ Fix lat/long and pop dialog when returning from observation.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/pull/20*event-8617150663__;Iw!!Mih3wA!GSfD6YNAidhEV_nvA7z61bof44HOvzbOXJI7A_0Fo6TgWKmW6wX4LHMOzA_y_BIxMk92irs-byq54ahoMwcODq9d$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV6LPWSOCZYP44SG6IB5HV3WZTCXRANCNFSM6AAAAAAVJRVGYU__;!!Mih3wA!GSfD6YNAidhEV_nvA7z61bof44HOvzbOXJI7A_0Fo6TgWKmW6wX4LHMOzA_y_BIxMk92irs-byq54ahoM6lU95Uu$ . You are receiving this because your review was requested.Message ID: @.***>

hundredball commented 1 year ago

Thanks for testing, Marina! I used an Android simulator as well. You can set the location of the emulator from the following steps. It should also reflect on the map page.

Screen Shot 2023-02-27 at 11 29 54 PM
hundredball commented 1 year ago

Hi Marina, I made two other changes when I tried to run app on iOS simulator.

mfrants commented 1 year ago

Hi Chieh

I'm not getting a map or any options to save points or set location when I open up the location screen:

Marina Frants Information Manager, CCE-LTER and CalCOFI Scripps Institution of Oceanography @.***

On Mon, Feb 27, 2023 at 11:35 PM Chieh Hsu @.***> wrote:

Thanks for testing, Marina! I used an Android simulator as well. You can set the location of the emulator from the following steps. It should also reflect on the map page. [image: Screen Shot 2023-02-27 at 11 29 54 PM] https://urldefense.com/v3/__https://user-images.githubusercontent.com/21293342/221784920-ecc44fee-5c4b-4cb1-9656-f8005e2a40d2.png__;!!Mih3wA!Bs8E0cF7HOuZjWzfxUTU08i0yjj1Mr12nDy7y0un8i031CeBHgmDvSirHw0jJiERZ9rEw8wz5N8b53rTz_ThhKV-$

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/pull/20*issuecomment-1447711077__;Iw!!Mih3wA!Bs8E0cF7HOuZjWzfxUTU08i0yjj1Mr12nDy7y0un8i031CeBHgmDvSirHw0jJiERZ9rEw8wz5N8b53rTz0m0PNyR$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV6LPWVWG4ZGHWICUS6GCYLWZWTFHANCNFSM6AAAAAAVJRVGYU__;!!Mih3wA!Bs8E0cF7HOuZjWzfxUTU08i0yjj1Mr12nDy7y0un8i031CeBHgmDvSirHw0jJiERZ9rEw8wz5N8b53rTz7qpc7tY$ . You are receiving this because your review was requested.Message ID: @.***>

hundredball commented 1 year ago

Hi @mfrants, I was wondering if you got a chance to test the lat/long on either Android or iOS. If that also works for you, I will merge the PR.

mfrants commented 1 year ago

Hi Chieh. I’m planning to do the testing today, and also to move the Log Out function to the profile page. I’ll let you know as soon as it’s done.

Marina Frants (she/her/hers) Information Manager, CCE-LTER/CalCOFI Scripps Institution of Oceanography, La Jolla, CA @.***

On Mar 13, 2023, at 8:31 AM, Chieh Hsu @.***> wrote:

Hi @mfrants https://urldefense.com/v3/__https://github.com/mfrants__;!!Mih3wA!FDqqDOdIZ_trJeI2HPZVwVfqSEcbSmQ3cPhui1KPiY5sZOvjxYot1m89CPJ-2rg7MDB4bSdJPBvEVSJZn9x1HVs0$, I was wondering if you got a chance to test the lat/long on either Android or iOS. If that also works for you, I will merge the PR.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/pull/20*issuecomment-1466371790__;Iw!!Mih3wA!FDqqDOdIZ_trJeI2HPZVwVfqSEcbSmQ3cPhui1KPiY5sZOvjxYot1m89CPJ-2rg7MDB4bSdJPBvEVSJZnyAqcs5n$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV6LPWXKG7FRB44OMSJAE7LW344VDANCNFSM6AAAAAAVJRVGYU__;!!Mih3wA!FDqqDOdIZ_trJeI2HPZVwVfqSEcbSmQ3cPhui1KPiY5sZOvjxYot1m89CPJ-2rg7MDB4bSdJPBvEVSJZn2WDqB1k$. You are receiving this because you were mentioned.

mfrants commented 1 year ago

Hi Chieh

I've moved the Log Out function from the welcome page to the profile page. Since it's a very small change, I pushed it into the same lat/long bug fix branch.

However, I'm still unable to get the lat long to show up in my upload screen. I followed the instruction in the link you found ( https://stackoverflow.com/questions/2279647/how-to-emulate-gps-location-in-the-android-emulator), but the Send button on the location screen has no effect for me. I think the problem is somewhere in my local machine configuration rather than in your code, so if it's working for you, I think it's okay to go ahead and merge the pull request. Marina Frants Information Manager, CCE-LTER and CalCOFI Scripps Institution of Oceanography @.***

On Mon, Mar 13, 2023 at 9:03 AM Marina Frants @.***> wrote:

Hi Chieh. I’m planning to do the testing today, and also to move the Log Out function to the profile page. I’ll let you know as soon as it’s done.

Marina Frants (she/her/hers) Information Manager, CCE-LTER/CalCOFI Scripps Institution of Oceanography, La Jolla, CA @.***

On Mar 13, 2023, at 8:31 AM, Chieh Hsu @.***> wrote:

Hi @mfrants https://urldefense.com/v3/__https://github.com/mfrants__;!!Mih3wA!FDqqDOdIZ_trJeI2HPZVwVfqSEcbSmQ3cPhui1KPiY5sZOvjxYot1m89CPJ-2rg7MDB4bSdJPBvEVSJZn9x1HVs0$, I was wondering if you got a chance to test the lat/long on either Android or iOS. If that also works for you, I will merge the PR.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/pull/20*issuecomment-1466371790__;Iw!!Mih3wA!FDqqDOdIZ_trJeI2HPZVwVfqSEcbSmQ3cPhui1KPiY5sZOvjxYot1m89CPJ-2rg7MDB4bSdJPBvEVSJZnyAqcs5n$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV6LPWXKG7FRB44OMSJAE7LW344VDANCNFSM6AAAAAAVJRVGYU__;!!Mih3wA!FDqqDOdIZ_trJeI2HPZVwVfqSEcbSmQ3cPhui1KPiY5sZOvjxYot1m89CPJ-2rg7MDB4bSdJPBvEVSJZn2WDqB1k$ . You are receiving this because you were mentioned.Message ID: @.***>

hundredball commented 1 year ago

Hi Marina, I tested it on TestFlight and it also showed 0,0. I will need to do further testing on iOS device.