Photo library doesn't work as expected

[hundredball]

Reproduce step

• Use photo library
• Sometimes multiple photos can be selected
• After choosing one photo and go into observation page, press back button and leave without saving
• Use photo library and select any photo
• The page will be navigated to upload page instead of observation page

Expected

• Only one photo can be selected in photo library
• After selecting one photo, the page should be directed to observation page every time

[hundredball]

Hi @mfrants, could you assign one of the issues from #21 or #22 to yourself and I will address another one? Thank you so much!

[mfrants]

Hi Chieh

I’ve assigned bug #22 to myself.

Marina Frants (she/her/hers) Information Manager, CCE-LTER/CalCOFI Scripps Institution of Oceanography, La Jolla, CA @.***

On Mar 16, 2023, at 8:11 AM, Chieh Hsu @.***> wrote:

Hi @mfrants https://urldefense.com/v3/__https://github.com/mfrants__;!!Mih3wA!H4YKbkanvDQvX8hCvQxprWj0ZChWrsetBM_AXcORC26eGge0R-XlsXge_YBvf9nW483Wy8nwOYhMoENrs_hYfINM$, could you assign one of the issues from #21 https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/issues/21__;!!Mih3wA!H4YKbkanvDQvX8hCvQxprWj0ZChWrsetBM_AXcORC26eGge0R-XlsXge_YBvf9nW483Wy8nwOYhMoENrs8iJfT7D$ or #22 https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/issues/22__;!!Mih3wA!H4YKbkanvDQvX8hCvQxprWj0ZChWrsetBM_AXcORC26eGge0R-XlsXge_YBvf9nW483Wy8nwOYhMoENrsydTsWCC$ to yourself and I will address another one? Thank you so much!

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/issues/22*issuecomment-1472170171__;Iw!!Mih3wA!H4YKbkanvDQvX8hCvQxprWj0ZChWrsetBM_AXcORC26eGge0R-XlsXge_YBvf9nW483Wy8nwOYhMoENrsxDawjEQ$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV6LPWSWGXN7YQ4L5XGOGKLW4MUT5ANCNFSM6AAAAAAV5LCFZY__;!!Mih3wA!H4YKbkanvDQvX8hCvQxprWj0ZChWrsetBM_AXcORC26eGge0R-XlsXge_YBvf9nW483Wy8nwOYhMoENrs3U11jxF$. You are receiving this because you were mentioned.

[hundredball]

Hi Marina, I fixed the bug for location and it works on iOS device now. You can proceed your fix on the main branch.

In terms of testing on iOS device, you can set up environment according to following picture and simply run and deploy the app to your device when it's physically connected to your Mac. Please let me know if you still have problem setting it up.

[mfrants]

Thanks, Chieh

I’ll check out the main branch and proceed there.

I was able to replicate the photo library bug, but am still trying to figure out what’s causing it. It seems to happen if go to ‘Albums’ in my photo gallery to select a photo, rather than the ‘all photos’ gallery.

I also noticed another issue when I was testing. If I selected a random no-animal photo and try to identify it with iNaturalist, it just kept spinning forever without returning a result. I had to quit the app to get out of it. I think we should have some sort of timeout, maybe 60 or 90 seconds, and return an “unable to identify species” message if iNaturalist fails. We can include a suggestion for users to use the text search function if they can’t identify by photo.

Cheers, Marina Frants (she/her/hers) Information Manager, CCE-LTER/CalCOFI Scripps Institution of Oceanography, La Jolla, CA @.***

On Mar 22, 2023, at 11:33 PM, Chieh Hsu @.***> wrote:

Hi Marina, I fixed the bug for location and it works on iOS device now. You can proceed your fix on the main branch.

In terms of testing on iOS device, you can set up environment according to following picture and simply run and deploy the app to your device when it's physically connected to your Mac. Please let me know if you still have problem setting it up. https://urldefense.com/v3/__https://user-images.githubusercontent.com/21293342/227122204-1a9bd3de-f03d-43c3-ae43-480eb5e3ade3.png__;!!Mih3wA!BKSGUXYZ0mJzCBdRtKwis4nTbMt2xWs9MLxneANXAZwMif3-dYQWp4BS4Pa6p2bgqMLpHszpdgZEkWlNIm8SMgqT$ — Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/issues/22*issuecomment-1480667621__;Iw!!Mih3wA!BKSGUXYZ0mJzCBdRtKwis4nTbMt2xWs9MLxneANXAZwMif3-dYQWp4BS4Pa6p2bgqMLpHszpdgZEkWlNInXQo0Im$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV6LPWTNGPOZPTBFEPNVHCLW5PVFLANCNFSM6AAAAAAV5LCFZY__;!!Mih3wA!BKSGUXYZ0mJzCBdRtKwis4nTbMt2xWs9MLxneANXAZwMif3-dYQWp4BS4Pa6p2bgqMLpHszpdgZEkWlNIgIaFazD$. You are receiving this because you were mentioned.

[hundredball]

Nice catch Marina! Yes, it's a good idea we set the time limit for searching. I think it would be great to also set time limit for text search as well.

[mfrants]

Hi Chieh.

I committed a change in extract_exif.dart that I think fixes the photo library bug. At least, I can't make it happen anymore, when before I could make it happen easily. Git was giving me a bunch of errors when I tried to check out main, so to speed things up I just made the change directly in github and committed it. It was just a small one-line thing, so hopefully that's okay.

Marina Frants Information Manager, CCE-LTER and CalCOFI Scripps Institution of Oceanography @.***

On Wed, Mar 22, 2023 at 11:34 PM Chieh Hsu @.***> wrote:

Hi Marina, I fixed the bug for location and it works on iOS device now. You can proceed your fix on the main branch.

In terms of testing on iOS device, you can set up environment according to following picture and simply run and deploy the app to your device when it's physically connected to your Mac. Please let me know if you still have problem setting it up. [image: Screen Shot 2023-03-22 at 11 31 04 PM] https://urldefense.com/v3/__https://user-images.githubusercontent.com/21293342/227122204-1a9bd3de-f03d-43c3-ae43-480eb5e3ade3.png__;!!Mih3wA!BKSGUXYZ0mJzCBdRtKwis4nTbMt2xWs9MLxneANXAZwMif3-dYQWp4BS4Pa6p2bgqMLpHszpdgZEkWlNIm8SMgqT$

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/issues/22*issuecomment-1480667621__;Iw!!Mih3wA!BKSGUXYZ0mJzCBdRtKwis4nTbMt2xWs9MLxneANXAZwMif3-dYQWp4BS4Pa6p2bgqMLpHszpdgZEkWlNInXQo0Im$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV6LPWTNGPOZPTBFEPNVHCLW5PVFLANCNFSM6AAAAAAV5LCFZY__;!!Mih3wA!BKSGUXYZ0mJzCBdRtKwis4nTbMt2xWs9MLxneANXAZwMif3-dYQWp4BS4Pa6p2bgqMLpHszpdgZEkWlNIgIaFazD$ . You are receiving this because you were mentioned.Message ID: @.***>

[hundredball]

Hi Marina,

Thanks for identifying this issue. As I tested, it also fixes another issue the metadata wasn't successfully loaded on my device.

I think the reason why you got lots of errors when checkout to main might be due to the commit conflict. We can briefly discuss it in the meeting tomorrow in case it happened again. Thanks for fixing this issue though! It works well so far :)