search

CalCOFI / OceanView

App that can incentivize ocean users to report their observations
1 stars 0 forks source link

Checking in unfinished code before the cruise #43

Closed mfrants closed 6 months ago

mfrants commented 7 months ago

This isn't finished yet, but I'm putting it in so that we can both look it over before the next meeting.

mfrants commented 6 months ago

Thanks, Chieh! I did a git pull and tested everything one last time, then changed test_observations to observations and merged. We should be all up to date now.

Marina Frants Information Manager, CCE-LTER and CalCOFI Scripps Institution of Oceanography @.***

On Thu, Dec 21, 2023 at 11:03 PM Chieh Hsu @.***> wrote:

@.**** approved this pull request.

Hi Marina, thanks for making these changes! I resolved merge conflicts and refactored codes a little bit. Everything works for me now. If they look good to you as well, you can change test_observations to observations and merge PR. I will migrate current observations collection to use new schema after this PR is merged.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/CalCOFI/OceanView/pull/43*pullrequestreview-1794056587__;Iw!!Mih3wA!GJ5thf5HReFYDYut0gIH4mTPd_kEyDotBcJoINhOj-y1zvRyYkR1u4OuSK-kjMqd2MLoEF-DGI8myBTT1QAcd_Yk$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV6LPWTIYTS4ZUPOLMA2IM3YKUWD7AVCNFSM6AAAAAA7TINJJGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJUGA2TMNJYG4__;!!Mih3wA!GJ5thf5HReFYDYut0gIH4mTPd_kEyDotBcJoINhOj-y1zvRyYkR1u4OuSK-kjMqd2MLoEF-DGI8myBTT1Xeos78F$ . You are receiving this because you authored the thread.Message ID: @.***>

hundredball commented 6 months ago

Hi @mfrants, thanks for merging. I updated observations collection accordingly and it worked for me!