Open eroux opened 3 years ago
@eroux do you want to just separate to phugpa
and tsurphu
? Or those are not "sub-codes" but just the direct name?
I'm wondering if adding sub-codes will make the structure too complex. Ping @ribose-jeffreylau .
I think we can just separate these yes. The most important is that we have two different IDs so that we can map the dates to the Gregorian ones. I'm not sure encoding the information that they are related is very relevant to the document?
@eroux the codes tibetan-phugpa
and tibetan-tsurphu
could work without us needing to create a model structure for "subcodes".
On the other hand, it is possible to create relationships between the calendars, such as marking them as "related". If preferred.
A real-life use case is the Tibetan calendar which has 2 distinct calculation traditions, usually referred to as "phugpa" and "Tsurphu". What would be the best way to encode this given the structure of https://github.com/CalConnect/csd-calendar-systems/blob/master/sources/data/codes.yaml ?