search

CalConnect / csd-calendar-systems

CC/ISO 34300 Date and time -- Codes for calendar systems
4 stars 2 forks source link

Should we have calendar "subcodes"? #16

Open eroux opened 3 years ago

eroux commented 3 years ago

A real-life use case is the Tibetan calendar which has 2 distinct calculation traditions, usually referred to as "phugpa" and "Tsurphu". What would be the best way to encode this given the structure of https://github.com/CalConnect/csd-calendar-systems/blob/master/sources/data/codes.yaml ?

eroux commented 3 years ago

here's a first pass: https://github.com/CalConnect/csd-calendar-systems/commit/a3555c7055a4559873c3039d60df8d9e91200ab1

ronaldtse commented 3 years ago

@eroux do you want to just separate to phugpa and tsurphu? Or those are not "sub-codes" but just the direct name?

I'm wondering if adding sub-codes will make the structure too complex. Ping @ribose-jeffreylau .

eroux commented 3 years ago

I think we can just separate these yes. The most important is that we have two different IDs so that we can map the dates to the Gregorian ones. I'm not sure encoding the information that they are related is very relevant to the document?

ronaldtse commented 3 years ago

@eroux the codes tibetan-phugpa and tibetan-tsurphu could work without us needing to create a model structure for "subcodes".

On the other hand, it is possible to create relationships between the calendars, such as marking them as "related". If preferred.