search

CalConnect / csd-calendar-systems

CC/ISO 34300 Date and time -- Codes for calendar systems
4 stars 2 forks source link

add year cycle for Tibetan and some Hindu calendars? #28

Open eroux opened 3 years ago

eroux commented 3 years ago

I just need to clarify something before making a proposal: at some point we discussed the idea of encoding the year cycle number in https://github.com/CalConnect/csd-calendar-systems/issues/9 but in this issue we decided that these can be encoded as eras (to which we can give codes). Now, in a meeting (can't remember which one but it was the one where the issues I brought up were discussed, a few months ago), we decided something else: that there should be a new integer field named "year cycle number". I'm not really sure where to find the meeting notes, and I think both solutions are ok (although I have a preference for the second one which is more flexible), but I just want to make sure I'm not doing something against the decision rules if I propose a change. @ronaldtse wdyt?

ronaldtse commented 3 years ago

Since there was already consensus that this problem needs to be addressed, please feel free to implement the preferred change.

eroux commented 3 years ago

ok thanks!