CalNourish / pantry-webapp

Pantry web app built with Next.js
https://www.ucbbncfp.com/
MIT License
8 stars 0 forks source link

Hide out-of-stock items on order page by default #135

Closed janiseliang closed 1 year ago

janiseliang commented 1 year ago

current default is to show out of stock items. seems a bit cluttered when there's a lot of items that can't even be ordered.

changed default to hidden

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ucbpfa-pantry-webapp ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 8:35AM (UTC)
justinazhang commented 1 year ago

Hmm let me ask Natalia about this, honestly I feel like we haven't been doing a great job with making sure inventory is in stock/not in stock but def agree this would be useful once it's accurate

Edit: nvm we're just gonna try and make inventory accurate lol

justinazhang commented 1 year ago

Screen Shot 2023-01-26 at 12 20 53 PM Also side note we should probably change line 45 maxQuantity == 0 to maxQuantity <= 0, but lowkey it's kind of nice because we reset the inventory to zero each week so if something's in the negative that means we probably have it since it's being checked out so maybe just hide the oos label? ... idk curious about your thoughts