Aesthetic issue in officer page

CalPolySEC / thewhitehat.club

The White Hat Website

https://thewhitehat.club

MIT License

1 stars 3 forks source link

Aesthetic issue in officer page #21

Closed sig1nt closed 4 years ago

sig1nt commented 5 years ago

Describe the bug See screenshot

Website Page URL https://thewhitehat.club/officers

To Reproduce Steps to reproduce the behavior:

Go to https://thewhitehat.club/officers
Notice the placement of the bottom officer pictures

Expected behavior Officer pictures should remain above the footer bar despite screen size

Screenshots

Desktop (please complete the following information):

Hardware: Macbook Pro 2016, 15'
OS: MacOS 10.13.6
Browser Firefox 65.0

jon77p commented 5 years ago

The size it's breaking at is 936x615 for the officer-container div, TODO: fix presumably vertical scaling of internal contents

slashnick commented 5 years ago

Unsubscribe On Sat, Feb 16, 2019 at 1:27 PM Jon Prentice notifications@github.com wrote:

The size it's breaking at is 936x615 for the officer-container div, TODO: fix presumably vertical scaling of internal contents

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/WhiteHatCP/thewhitehat.club/issues/21#issuecomment-464387385, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzNn7jVupqT8U2UImNdSoFb-00QHx36ks5vOHergaJpZM4a-iP4 .

sjfoz1019 commented 4 years ago

Added scrolling to accommodate a larger number of officers in #a7cbde0 so this bug is no longer noticable, but probably still exists.

jon77p commented 4 years ago

Closing due to partial fix