Closed sig1nt closed 8 years ago
Also, our test cases don't work, so Travis is lying to us
If the tests are broken, we should probably fix those
Do the test's work on your computer? For me they run into problems with the tests not being sandboxed
Alright, I have a PR in to @nickfrostatx's branch to fix the tests, then we can revisit a merge
Huh?
On Thu, Sep 1, 2016, 8:59 AM Nick Gonella notifications@github.com wrote:
Closed #8 https://github.com/DeltaHeavy/wrath-ctf-framework/pull/8.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DeltaHeavy/wrath-ctf-framework/pull/8#event-775379079, or mute the thread https://github.com/notifications/unsubscribe-auth/AFOJX13yVjsWeOmwI5ESLydb2Zz44rY-ks5qlvZfgaJpZM4JyA3J .
Max Zinkus
I didn't want to have this PR just sitting there, so we'll reopen it once we get the PR merged that fixes the test cases.
This is a running PR from my master, which is in sync with @nickfrostatx, to the repository master. All the code in this has been reviewed already and just needs to be merged.