search

Calamari-OCR / calamari

Line based ATR Engine based on OCRopy
Apache License 2.0
1.04k stars 209 forks source link

Code refactoring #345

Closed tosemml closed 1 year ago

tosemml commented 1 year ago

These slight code adjustments aim to enhance Pythonic quality by incorporating python str.join

andbue commented 1 year ago

Thanks for the effort, but I don't think such a tiny and purely aesthetic change warrants a pull request.

tosemml commented 1 year ago

Thanks for the comment. Please update the contribution guidelines with the minimum size of the PR that we should consider. Thanks.

andbue commented 1 year ago

Well, I don't now the objective of your project, but I'm sceptical about the benefits of this kind of PR (I had a similar case where they made a less than ideal suggestion: https://github.com/Calamari-OCR/calamari/pull/329). My first impression was that it coerces projects into reviewing unclear improvements suggested by some kind of code analysis (maybe even by some large language model) and that this is not something I would want to encourage. Maybe this is what you want to find out – I'd be really interested in some background information about your study!