search

CalderaWP / Caldera-Forms

Drag and drop, responsive WordPress form builder.
https://CalderaForms.com
GNU General Public License v2.0
187 stars 163 forks source link

Checking the "Attach To Mailer" Option adds file to media library #2944

Closed swapnilmanjrekar closed 5 years ago

swapnilmanjrekar commented 5 years ago

Do You Need Immediate Help?

Is This A Feature Request?

What Version Of Caldera Forms, WordPress and PHP Are You Using?

Does Your Issue Persist When You Disable All Other Plugins and Switch To The Default Theme?

What Is The Unexpected Behaviour?

What PHP Errors Have You Logged While Reproducing This Bug?

What JavaScript Errors Have You Seen While Reproducing This Bug?

Shelob9 commented 5 years ago

@swapnilmanjrekar You titled this issue Files getting uploaded to media library even after unchecking media library option in form setting I am assuming because you said "unchecking" that to reproduce this issue I need to:

  1. Create a form with a advanced file field 2.0 and check the "Upload To Media Library" option.
  2. Save form.
  3. Refresh page and uncheck the "Upload To Media Library" option.
  4. Save form.

Then I should see that submitting the form results int he file being uploaded to media library when I would expect it not to.

I am also assuming that if I create a form with a advanced file field 2.0 and do not check the "Upload To Media Library" option that I will not see this bug, since I did not uncheck the option.

Am I correct?

swapnilmanjrekar commented 5 years ago

@Shelob9 Yes, Correct.

Shelob9 commented 5 years ago

I tested this issue and am able to reproduce if "attach to mailer" is checked. File is always added to media library.

Shelob9 commented 5 years ago

This form reproduces the issue: 2895-forms.zip

Shelob9 commented 5 years ago

Should be resolved via #2951

swapnilmanjrekar commented 5 years ago

This form reproduces the issue: 2895-forms.zip @Shelob9 I believe this form is not related to this issue.

swapnilmanjrekar commented 5 years ago

@Shelob9 This is the correct form to test.

2944.zip

New0 commented 5 years ago

Closed by https://github.com/CalderaWP/Caldera-Forms/commit/b0a47b5b4e59365d9b67286ebeb7960ba2583a20