CalderaWP / Caldera-Forms

Drag and drop, responsive WordPress form builder.
https://CalderaForms.com
GNU General Public License v2.0
188 stars 163 forks source link

Incremental Value processor breaks form saving #3670

Closed MontreatDesigner closed 3 years ago

MontreatDesigner commented 3 years ago

Do You Need Immediate Help?

No

Is This A Feature Request?

No, a semi-serious bug

What Version Of Caldera Forms, WordPress and PHP Are You Using?

WordPress Version: 5.6 PHP Version: 7.4.13 MySQL Version: 5.7.31 Caldera Forms Version: 1.9.3

Does Your Issue Persist When You Disable All Other Plugins and Switch To The Default Theme?

What Is The Unexpected Behaviour?

Forms lose the ability to save when Incremental Value processors are given an Increment Field. The form will allow you to save so long as the page remains live, but upon reload the save button pops up and then disappears. This breaks all future editing to the form. Adding {increment_capture:increment_value} to a hidden field bypasses the problem.

Artificially giving the page a save button by copying and pasting the button code from a working form doesn't work. This wouldn't be a huge issue if I were able to remove the Increment Field from the database so I could fix my forms, but PHP really doesn't like serializing/deserializing html values.

What PHP Errors Have You Logged While Reproducing This Bug?

None.

What JavaScript Errors Have You Seen While Reproducing This Bug?

Uncaught TypeError: Cannot read property 'split' of undefined at index.min.js?ver=1.9.3:1 at te (index.min.js?ver=1.9.3:1) at Object.Vc [as useReducer] (react-dom.min.js?ver=16.13.1:87) at Object.d.useReducer (react.min.js?ver=16.13.1:32) at re (index.min.js?ver=1.9.3:1) at we (react-dom.min.js?ver=16.13.1:84) at He (react-dom.min.js?ver=16.13.1:97) at zj (react-dom.min.js?ver=16.13.1:228) at Th (react-dom.min.js?ver=16.13.1:152) at tj (react-dom.min.js?ver=16.13.1:152)

MontreatDesigner commented 3 years ago

This is fixed with release 1.9.4-b1. I expect it will remain fixed with the next release full release.