Use single shortcode with a better media view to it doesn't break inline placement of modal links.

[DavidCramer]

Since I have a media view to render the form in the editor, it now makes it impossible to do inline modal triggers. The media view causes the content after to be wrapped in <p></p>

This was actually one of the reasons I initially had the [caldera_form_modal] shortcode since it doesn't use a registered view.

[DavidCramer]

@Shelob9 - take a look at 2e3e8bd to address this issue. I know that you deprecated the shortcode, but this at least makes it so you can make links trigger a modal without making new lines.

[DavidCramer]

@Shelob9 - I actually did merge this with dev already. just test it out first and see what you think.

[Shelob9]

@Desertsnowman I really like the UI on this, but I think that having two shortcodes is uneeded. Also we now have two ways to create a modal, since existing shortcode supports it.

Why not move your new way of making a modal into Caldera_Forms::shortcode_handler() and use if $atts[ 'modal' ] is true?

[DavidCramer]

Try create an inline link in the visual editor. As a modal and see what happens.

[Shelob9]

I see this, but that's a bad reason to create two different shortcodes. If it's an easy fix, then fix that, but if not, I'll live with it for now. What I don't like is two similar shortcodes with slightly different features and the odd way it is implimented right now.

[DavidCramer]

Ideally I need to figure out how to use the media view that images have. The current form preview in editor is at a block level. Also there is no way that, I know of, to use the view conditionally.

this gif explains the issue

[DavidCramer]

I'll review this for 1.3.6 while I look for a better way to achieve it. for now let's leave the two shortcodes.