CalderaWP / caldera-custom-fields

Save Caldera Forms submissions in a post type or use Caldera Forms to create custom metaboxes.
https://calderaforms.com/downloads/caldera-form-custom-fields/
7 stars 11 forks source link

#32 Save numeric strings as strings and not as int #33

Closed New0 closed 7 years ago

Shelob9 commented 7 years ago

Copy of what @New0 said in slack

nico [10:34 AM] I worked on the PR for the issue 32 described above.

The new terms were already saved, only the numbers field wouldn't save so I tested saving numeric strings as strings and not as int and it worked.

At this point the form of Joe that we base this work on works. BUT

I needed to test as much as I could and found a scenario where it doesn't work :

I think / deduct that if the value is set to name it works for single and multiple values as expected but if the value is set to ID it only works for multiple values and not single ones.

All the other scenarios I tested were successful, I think I can fix that but I won't be able to work on that before Thursday so You may want to take care of it (edited)