Open kolhoffmmm opened 9 years ago
@kolhoffmmm Thanks for this PR. It's a great idea, and I would merge it, but I think you might have based it on an out of date version. If you look at the diff, after line 36 of the render class, you are removing a bunch of stuff. Can you update the PR please?
Will do so I'll work on it this weekend. Our weekend in South Africa has just started so time to relax a bit. So hopefully late Saturday afternoon.
Regards
Mouring
On Fri, May 22, 2015 at 4:20 PM, Josh Pollock notifications@github.com wrote:
@kolhoffmmm https://github.com/kolhoffmmm Thanks for this PR. It's a great idea, and I would merge it, but I think you might have based it on an out of date version. If you look at the diff, after line 36 of the render class, you are removing a bunch of stuff. Can you update the PR please?
— Reply to this email directly or view it on GitHub https://github.com/CalderaWP/metaplate-core/pull/5#issuecomment-104672482 .
Mouring Kolhoff http://www.smesolutions.co.za Cell +27-84-5053594 Office +27-12-6673245 Fax 086 663 8801
Hi Josh,
I tried to modify based on the new metaplatecore
https://github.com/CalderaWP/metaplate-core/
But when I edit the following file
https://github.com/CalderaWP/metaplate-core/edit/master/src/render.php
and save it to my local environment in wordpress based on
the up to date plugin
https://wordpress.org/plugins/caldera-metaplate/
I get the following error message
Fatal error: Uncaught exception 'InvalidArgumentException' with message 'vardump Helper is not a callable or doesn't implement the Helper interface.' in C:\Users\Mouring\Desktop\New Servers\Server 5 cfs shuttle\UwAmp\www\wp-content\plugins\caldera-metaplate\vendor\xamin\handlebars.php\src\Handlebars\Helpers.php on line 102
SO I guess the wordpress plugin is not 100% up to date with metaplate-core
Regards
Mouring
On Fri, May 22, 2015 at 4:20 PM, Josh Pollock notifications@github.com wrote:
@kolhoffmmm https://github.com/kolhoffmmm Thanks for this PR. It's a great idea, and I would merge it, but I think you might have based it on an out of date version. If you look at the diff, after line 36 of the render class, you are removing a bunch of stuff. Can you update the PR please?
— Reply to this email directly or view it on GitHub https://github.com/CalderaWP/metaplate-core/pull/5#issuecomment-104672482 .
Mouring Kolhoff http://www.smesolutions.co.za Cell +27-84-5053594 Office +27-12-6673245 Fax 086 663 8801
That's not going to work. You either need to check out the main repo https://github.com/CalderaWP/metaplate
and then do a composer update to get all the dependencies or just clone this repo and make the changes there.
Updated to allow extra data to be passed to be used in the template
To be used as follows
$extra_data['hats']='ddd'; $file = 'test.html'; echo caldera_metaplate_from_file( $file, $post_id, null, $extra_data);