search

CalebBarnes / nextwp

http://nextwp.org/
7 stars 0 forks source link

WIP: added taxonomy pages to sitemap #49

Open Renesauve opened 5 months ago

Renesauve commented 5 months ago

Just seeing if it breaks or not here:

Still need to add pagination

Example

/blog/ /blog/1 ? /blog/2

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-wordpress-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 9:15pm
nextwp-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 9:15pm
Renesauve commented 5 months ago

For whatever reason the postType post.has_archive === false

not sure why this might be

CalebBarnes commented 5 months ago

For whatever reason the postType post.has_archive === false

not sure why this might be

Is this happening just for the nextwordpress.wpengine.com used in the starter example, or for all WP sites?

CalebBarnes commented 5 months ago

Also, you should review the getPageData function to see how we are currently including taxonomy and term pages.

If I remember correctly, I think for any post type that is enabled, we are just getting all taxonomies that are used on that post type, not just getting all taxonomies for everything.

Renesauve commented 5 months ago

Also, you should review the getPageData function to see how we are currently including taxonomy and term pages.

If I remember correctly, I think for any post type that is enabled, we are just getting all taxonomies that are used on that post type, not just getting all taxonomies for everything.

Thanks for the tip! I'll take a look and see if I can reduce the complexity

Renesauve commented 5 months ago

For whatever reason the postType post.has_archive === false not sure why this might be

Is this happening just for the nextwordpress.wpengine.com used in the starter example, or for all WP sites?

ill test this

Renesauve commented 5 months ago

it's woooooooooooooorking!!!!! did it break anything?

i don't know

CalebBarnes commented 4 months ago

It would be great if we could write a test for generateStaticParams and generateSitemap and make sure these are always generating the same page urls.

Renesauve commented 4 months ago

It would be great if we could write a test for generateStaticParams and generateSitemap and make sure these are always generating the same page urls.

YEAH! I was also thinking that considering it's starting to get more complex, what would you recommend for testing?