CalebBell / chemicals

chemicals: Chemical database of Chemical Engineering Design Library (ChEDL)
MIT License
186 stars 36 forks source link

Vs in COSTALD_compressed should be Vsat? #43

Open jgostick opened 2 years ago

jgostick commented 2 years ago

In the COSTALD_compressed method, and perhaps others, there is an argument Vs for saturation volume. It was my impression that the suffix s on an argument name meant plural as in the properties of each component in the mixture. I am trying to write a wrapper for these functions, and have been relying on this implied API (any arg ending with s triggers a look-up of properties from multiple phases). I think this Vs should be Vsat. Also, I hope that am correct about you reserving the s suffix for mixture properties because this is quite handy. If this is just a loose convention, might I suggest or request that you consider making it a hard-coded fact?