CalebBell / chemicals

chemicals: Chemical database of Chemical Engineering Design Library (ChEDL)
MIT License
186 stars 36 forks source link

Hidden vs public data files and naming convention #7

Closed yoelcortes closed 4 years ago

yoelcortes commented 4 years ago

About half of the data files are hidden with a leading underscore and the other half are public. And although there is a suggested convention for data within a module, there is no convention between the other modules. I propose the following convention:

I honestly don't mind whatever format we use (hidden or not). But as long as there is a convention we can follow, that would be dope.

yoelcortes commented 4 years ago

I also just noticed that some names have Dict, but are actually dataframes...

CalebBell commented 4 years ago

Hi Yoel, This seems like a great name convention. Good thinking! I think I went from the csv reader module, to a custom parser for everything based on to_num, played around with storing as numpy arrays, and then ended at pandas for most data reading things. I am not surprised the naming convention has been inconsistent!

yoelcortes commented 4 years ago

Thanks! Since part of this chemicals project is to expose the data, I'll keep these as public.

yoelcortes commented 4 years ago

I updated the convention so that its easier to autocomplete the names.