CalebBell / fluids

Fluid dynamics component of Chemical Engineering Design Library (ChEDL)
MIT License
350 stars 76 forks source link

model name bug in <two_phase.py> #40

Closed hohiroki closed 3 years ago

hohiroki commented 3 years ago

line 2507: the model name "Beggs-Brill" might be revised as "Beggs_Brill"

CalebBell commented 3 years ago

Hi hohiroki, I see the inconsistency in that some of the options use a underscore and this one use dash. I try to avoid breaking backwards compatibility pretty hard, so I'm afraid this will stay as it is as there are people using those code. Cheers, Caleb