search

CalebBell / fluids

Fluid dynamics component of Chemical Engineering Design Library (ChEDL)
MIT License
350 stars 76 forks source link

Fix Martin Correlation #57

Closed PierreLesouhaitier closed 1 year ago

PierreLesouhaitier commented 1 year ago

Dear maintainers,

Thank you very much for developing this very useful library.

After reading the paper Martin1996 (https://www.sciencedirect.com/science/article/abs/pii/025527019504129X?via%3Dihub) and the dedicated chapter in the VDI Heat Atlas, it appeared that there is a variable mistake. The friction factors takes as input the chevron_angle and not the plate_enlargement_factor as suggested.

As chevron_angle are always considered to be in degrees elsewhere in the code, I kept them in degrees for Martin Correlation as well.

Best regards,

Pierre

PS: After reading the issues, it fixes some of the concerns of #54

CalebBell commented 1 year ago

Thank you Pierre! I appreciate you following up on this. I am trying to get a new set of library releases out there soon. Sincerely, Caleb