Closed BenPortner closed 1 year ago
Hey Ben, The reason is that I needed to add logic which made it as likely as possible CoolProp would converge. When retrieving ideal gas heat capacity from CoolProp via the PropsSI interface, CoolProp will do a full flash; and sometimes it fails.
I have experimented with using the heat capacity coefficients from CoolProp directly, but there are quite a few terms CoolProp has implemented and have not implemented them all yet. You can see the progress here: https://github.com/CalebBell/thermo/blob/master/thermo/coolprop.py#L483
Sincerely, Caleb
I was able to add the H2 term to the pure-python implementation fairly easily because it was a different form of a term already implemented. The next thermo release will have the full temperature range. As a bonus, CH4 and N2 were added from the same code. Caleb
Hello @CalebBell,
Thank you so much for the quick implementation! Amazing work :) I will close this issue now.
Thanks again. Ben
Hi @CalebBell,
Thermo shows the following temperature limits for the
HeatCapacityGas
class using hydrogen (code below). ForCOOLPROP
, a maximum temperature corresponding to T_crit = 33.145 K is given. However, in CoolProp's documentation, a limit of 1000 K is given. Is there a specific reason why the recommended range in thermo is smaller?Thank you! Ben