search

CalebBell / thermo

Thermodynamics and Phase Equilibrium component of Chemical Engineering Design Library (ChEDL)
MIT License
594 stars 114 forks source link

Documentation #44

Closed dejac001 closed 3 years ago

dejac001 commented 4 years ago

see line below: need to change x_i to y_i

https://github.com/CalebBell/thermo/blob/cba02552ea1a6947fcaa8407d4553e42e248e77c/thermo/eos_mix.py#L177

dejac001 commented 4 years ago

below, need to change log to ln to be consistent

https://github.com/CalebBell/thermo/blob/cba02552ea1a6947fcaa8407d4553e42e248e77c/thermo/eos_mix.py#L481

CalebBell commented 3 years ago

Hi Robert, Well spotted. I went out and did some searches throughout my code bases, there were probably 400ish references to log in formulas. Hopefully I got them all and now they are either ln or log_{10}. They will likely creep back in - many formulas come out of SymPy, which like all mathematical engines, considers log and ln to be the same. log10 is heretical! Sincerely, Caleb