Update mixture.py - Githubissues

CalebBell / thermo

Thermodynamics and Phase Equilibrium component of Chemical Engineering Design Library (ChEDL)

MIT License

594 stars 114 forks source link

Update mixture.py #51

Closed tedhyu closed 4 years ago

tedhyu commented 4 years ago

Hi: I want to make contributions to a github repository. I really appreciate what you are doing with this open source project, and hope I can contribute to it. I have a background in computational chemistry.

This is in response to the error reported in: Error calculating Joule-Thomson coef for mixture class #50

Created the following def:
isobaric_expansion_g isobaric_expansion_l

coveralls commented 4 years ago

Coverage increased (+0.04%) to 88.85% when pulling 1966c7cba5a603984b49f22c97ff00a144d90812 on tedhyu:master into cba02552ea1a6947fcaa8407d4553e42e248e77c on CalebBell:master.

CalebBell commented 4 years ago

Hi Ted,

Very good catch! Thank you for looking into this issue. You did a great job keeping with the documentation style! I am happy to merge it. Can you remove the .pyc files from your pull request? They are not conventionally committed to git as they are generated files from Python.

Sincerely, Caleb

CalebBell commented 4 years ago

Thank you very much!

tedhyu commented 4 years ago

Happy to hear. Cheers!