search

CalebBell / thermo

Thermodynamics and Phase Equilibrium component of Chemical Engineering Design Library (ChEDL)
MIT License
594 stars 114 forks source link

Remove all spaces/format chars from data files #60

Closed danieldjewell closed 3 years ago

danieldjewell commented 3 years ago

The use of spaces and/or other punctuation in filenames has been problematic for years. Even though modern OSes (usually) handle it somewhat OK, that can't be assumed. Older OSes (especially big *NIXes) could be especially problematic.

This renames all data files in the thermo/ directory to use underscores instead of spaces, removes (), and changes "-" to a single underscore. References to the files are also updated.

I ran the test suite and the results are the same pre/post. (Some of the tests failed on a clean copy of master -- is the test suite 100%?)

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 88.852% when pulling b49d3aaf3a5a49335bfbea6a63b5655ff711be22 on danieldjewell:death_to_0x20 into 9f4175a9bcebc450baeba0b4f62398686a804c27 on CalebBell:master.

CalebBell commented 3 years ago

Hi Daniel,

Escape characters for spaces have been supported on every popular OS for longer than I have been alive; tab-completion on pretty much any shell will add them for you. You could equally say unicode characters are an issue in the Python files themselves, to which I would say, upgrade your Python/OS.

I appreciate that you want to improve thermo, but it looks like work for no benefit to me. Is there a particular issue you are having I am unaware of?

Sincerely, Caleb