All tests passed except for some extremely slow marked tests, which I think might have been failing before the change (maybe you'd like to check it out?):
In addition, the pull request introduces some minor edits:
Use the R, R_inv, and R2 class attributes instead of module level variables (hopefully removing inconsistencies due to multiple R values available, like the IAPWS R).
Using __init_subclass__ to set the __full_path__ class attribute.
Minor bug fixes like:
Some methods had an undefined variable VaporPressures; changed it to self.VaporPressures
Some methods had an undefined variable xs; changed it to self.zs
phase == self.assigned_phase to phase = self.assigned_phase; but not sure if this is correct because assigned_phase is not mentioned anywhere else.
Other minor enhancements...
The documentation should be working the same as before since I exposed the documentation of all classes in the __init__ module of the phases subpackage. Not sure if moving the documentation of each class to separate modules is something we would like to do in the future.
Feel free to edit as you see fit before merging,
Hope this helps!
Hi Caleb,
This pull request refactors the phases.py module (well over 10,000 lines) into a subpackage with the following modules:
All tests passed except for some extremely slow marked tests, which I think might have been failing before the change (maybe you'd like to check it out?):
In addition, the pull request introduces some minor edits:
R,R_inv, andR2class attributes instead of module level variables (hopefully removing inconsistencies due to multiple R values available, like the IAPWS R).__init_subclass__to set the__full_path__class attribute.VaporPressures; changed it toself.VaporPressuresxs; changed it toself.zsphase == self.assigned_phasetophase = self.assigned_phase; but not sure if this is correct becauseassigned_phaseis not mentioned anywhere else.The documentation should be working the same as before since I exposed the documentation of all classes in the
__init__module of the phases subpackage. Not sure if moving the documentation of each class to separate modules is something we would like to do in the future.Feel free to edit as you see fit before merging, Hope this helps!