search

CalebBell / thermo

Thermodynamics and Phase Equilibrium component of Chemical Engineering Design Library (ChEDL)
MIT License
594 stars 114 forks source link

Refactor #81

Closed yoelcortes closed 3 years ago

yoelcortes commented 3 years ago

Hi Caleb,

This pull request refactors the utils.py module to a subpackage. I'm planning on doing a bit more work on the TDependentProperty and TPDependentProperty objects later, so separating these out to separate modules should help me work much faster.

I put miscellaneous functions in a module called "functional.py". Not sure if you have any better ideas to name this module...

Thanks!

CalebBell commented 3 years ago

Hi Yoel! As you probably noticed functional stuff all had something not great about it, that I hope to fix one day. I would have moved the rest of the functions to chemicals if they were all good and right. Thermo may never have had a re-release if I hadn't let many things go.

I also don't know if the MultiCheb class will ever be used again. It was a great performance tool before I got into PyPy and not numba, but I don't think the same numerical trick is really necessary there. Many optimizations in Pure-Python don't make any sense in a faster implementation of Python. That code also ended up being duplicated in CoolProp.py. I would consider it an implementation detail and if it were used in the future I would move it to fluids.numerics.

I was going to say I didn't know when I could get to reviewing your work but it turned out you had already resolved all the merge conflicts and everything merged well! Thank you. Sincerely, Caleb